[dpdk-dev] [PATCH v2] vhost: add experimental flag

Ferruh Yigit ferruh.yigit at intel.com
Fri Sep 27 21:31:31 CEST 2019


On 9/24/2019 10:23 AM, Jim Harris wrote:
> This function is listed under EXPERIMENTAL in the
> rte_vhost_version.map, so it needs to be marked
> with __rte_experimental in the header file as well.
> 
> Found by check-experimental-syms.sh when trying to compile
> DPDK with -finstrument-functions.  This script didn't
> catch this in the normal case, since the function is
> declared __rte_always_inline.
> 
> This also requires updating the vhost_scsi example to allow
> use of this newly marked experimental API.
> 
> Signed-off-by: Jim Harris <james.r.harris at intel.com>
> ---
>  examples/vhost_scsi/Makefile    |    2 ++
>  examples/vhost_scsi/meson.build |    1 +
>  lib/librte_vhost/rte_vhost.h    |    1 +
>  3 files changed, 4 insertions(+)
> 
> diff --git a/examples/vhost_scsi/Makefile b/examples/vhost_scsi/Makefile
> index c5aec269e..6015c0241 100644
> --- a/examples/vhost_scsi/Makefile
> +++ b/examples/vhost_scsi/Makefile
> @@ -27,6 +27,8 @@ CFLAGS += -O3 $(shell $(PKGCONF) --cflags libdpdk)
>  LDFLAGS_SHARED = $(shell $(PKGCONF) --libs libdpdk)
>  LDFLAGS_STATIC = -Wl,-Bstatic $(shell $(PKGCONF) --static --libs libdpdk)
>  
> +CFLAGS += -DALLOW_EXPERIMENTAL_API

example still fails to build, option needs to be enabled in the 'else' leg of
the makefile, I am fixing while merging to next-net.


More information about the dev mailing list