[dpdk-dev] [PATCH] net/iavf: enable port reset

Ye Xiaolong xiaolong.ye at intel.com
Wed Apr 1 05:38:41 CEST 2020


Hi, Lunyuan

On 03/25, Lunyuan Cui wrote:
>This patch is intended to add iavf_dev_reset ops, enable iavf to support
>"port reset all".
>
>Signed-off-by: Lunyuan Cui <lunyuanx.cui at intel.com>
>---
> drivers/net/iavf/iavf_ethdev.c | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
>
>diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c
>index 34913f9c4..01366bc3c 100644
>--- a/drivers/net/iavf/iavf_ethdev.c
>+++ b/drivers/net/iavf/iavf_ethdev.c
>@@ -32,6 +32,7 @@ static int iavf_dev_configure(struct rte_eth_dev *dev);
> static int iavf_dev_start(struct rte_eth_dev *dev);
> static void iavf_dev_stop(struct rte_eth_dev *dev);
> static void iavf_dev_close(struct rte_eth_dev *dev);
>+static int  iavf_dev_reset(struct rte_eth_dev *dev);
> static int iavf_dev_info_get(struct rte_eth_dev *dev,
> 			     struct rte_eth_dev_info *dev_info);
> static const uint32_t *iavf_dev_supported_ptypes_get(struct rte_eth_dev *dev);
>@@ -91,6 +92,7 @@ static const struct eth_dev_ops iavf_eth_dev_ops = {
> 	.dev_start                  = iavf_dev_start,
> 	.dev_stop                   = iavf_dev_stop,
> 	.dev_close                  = iavf_dev_close,
>+	.dev_reset		    = iavf_dev_reset,
> 	.dev_infos_get              = iavf_dev_info_get,
> 	.dev_supported_ptypes_get   = iavf_dev_supported_ptypes_get,
> 	.link_update                = iavf_dev_link_update,
>@@ -1416,6 +1418,23 @@ iavf_dev_uninit(struct rte_eth_dev *dev)
> 	return 0;
> }
> 
>+/*
>+ * Reset VF device only to re-initialize resources in PMD layer
>+ */
>+static int
>+iavf_dev_reset(struct rte_eth_dev *dev)
>+{
>+	int ret;
>+
>+	ret = iavf_dev_uninit(dev);
>+	if (ret)
>+		return ret;
>+
>+	ret = iavf_dev_init(dev);
>+
>+	return ret;

What about merging above 2 lines into

	return iavf_dev_init(dev);

Btw, this patch can't be applied to latest next-net-intel, could you rebase
and send a new version?

Thanks,
Xiaolong

>+}
>+
> static int eth_iavf_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,
> 			     struct rte_pci_device *pci_dev)
> {
>-- 
>2.17.1
>


More information about the dev mailing list