[dpdk-dev] [PATCH v2 10/14] net/igc: implement ether-type filter

[Ferruh Yigit]

On 3/20/2020 2:46 AM, alvinx.zhang at intel.com wrote:
> From: Alvin Zhang <alvinx.zhang at intel.com>
> 
> Update feature list too.
> 
> Signed-off-by: Alvin Zhang <alvinx.zhang at intel.com>
> ---
>  doc/guides/nics/features/igc.ini |   1 +
>  drivers/net/igc/Makefile         |   1 +
>  drivers/net/igc/igc_ethdev.c     |   5 +
>  drivers/net/igc/igc_ethdev.h     |  15 +++
>  drivers/net/igc/igc_filter.c     | 237 +++++++++++++++++++++++++++++++++++++++
>  drivers/net/igc/igc_filter.h     |  31 +++++
>  drivers/net/igc/meson.build      |   3 +-
>  7 files changed, 292 insertions(+), 1 deletion(-)
>  create mode 100644 drivers/net/igc/igc_filter.c
>  create mode 100644 drivers/net/igc/igc_filter.h
> 
> diff --git a/doc/guides/nics/features/igc.ini b/doc/guides/nics/features/igc.ini
> index f5c862b..95c41ee 100644
> --- a/doc/guides/nics/features/igc.ini
> +++ b/doc/guides/nics/features/igc.ini
> @@ -31,6 +31,7 @@ RSS key update       = Y
>  RSS reta update      = Y
>  VLAN filter          = Y
>  VLAN offload         = Y
> +Flow API             = P

This patch is not adding 'Flow API' support, but it is adding filter_ctrl
support for ETHERTYPE, which is deprecated [1].

I suggest dropping all filter_ctrl patches after this point, and implement the
filtering using flow API as additional series, what do you think?

[1]
https://git.dpdk.org/dpdk/tree/doc/guides/rel_notes/deprecation.rst?h=v20.02#n73