[dpdk-dev] [PATCH v2 04/14] net/igc: support reception and transmission of packets

Ferruh Yigit ferruh.yigit at intel.com
Fri Apr 3 14:27:33 CEST 2020


On 3/20/2020 2:46 AM, alvinx.zhang at intel.com wrote:
> From: Alvin Zhang <alvinx.zhang at intel.com>
> 
> Below ops are added too:
> mac_addr_add
> mac_addr_remove
> mac_addr_set
> set_mc_addr_list
> mtu_set
> promiscuous_enable
> promiscuous_disable
> allmulticast_enable
> allmulticast_disable
> rx_queue_setup
> rx_queue_release
> rx_queue_count
> rx_descriptor_done
> rx_descriptor_status
> tx_descriptor_status
> tx_queue_setup
> tx_queue_release
> tx_done_cleanup
> rxq_info_get
> txq_info_get
> dev_supported_ptypes_get
> 
> Signed-off-by: Alvin Zhang <alvinx.zhang at intel.com>
> 

<...>

>  static int
> -eth_igc_rx_queue_setup(struct rte_eth_dev *dev, uint16_t rx_queue_id,
> -		uint16_t nb_rx_desc, unsigned int socket_id,
> -		const struct rte_eth_rxconf *rx_conf,
> -		struct rte_mempool *mb_pool)
> +eth_igc_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)
>  {
> -	PMD_INIT_FUNC_TRACE();
> -	RTE_SET_USED(dev);
> -	RTE_SET_USED(rx_queue_id);
> -	RTE_SET_USED(nb_rx_desc);
> -	RTE_SET_USED(socket_id);
> -	RTE_SET_USED(rx_conf);
> -	RTE_SET_USED(mb_pool);
> +	struct igc_hw *hw = IGC_DEV_PRIVATE_HW(dev);
> +	uint32_t frame_size = mtu + IGC_ETH_OVERHEAD;
> +	uint32_t rctl;
> +
> +	/* if extend vlan has been enabled */
> +	if (IGC_READ_REG(hw, IGC_CTRL_EXT) & IGC_CTRL_EXT_EXT_VLAN)
> +		frame_size += VLAN_TAG_SIZE;

'IGC_CTRL_EXT_EXT_VLAN' is not defined until this patch, that is why compiling
this patch gives an build error.

This macro is defined in "[PATCH v2 09/14] net/igc: implement feature of VLAN",
can you please pull that definition into this patch to fix the build error?


More information about the dev mailing list