[dpdk-dev] [EXT] [PATCH v1 3/4] regexdev: add regexdev core functions

[Pavan Nikhilesh Bhagavatula]

Hi Ori,

>> From: dev <dev-bounces at dpdk.org> On Behalf Of Pavan Nikhilesh
>Bhagavatula
>>
>> Looks like this implementation is incomplete?
>> I don't see any pmd specific helper functions for @see
>rte_cryptodev_pmd.c,
>> rte_eventdev_pmd*
>>
>I think the current implementation includes all needed functions,
>at least for the first stage.
>You can find in rte_regexdev_driver.h the functions that should be
>called
>by the PMD. We have the register / unregister which acts the same as
>create
>and destroy. For parsing argument the PMD may call rte_kvargs_parse.
>

_driver.h should atleast include 
rte_regex_dev_pci_generic_probe/rte_regex_pmd_vdev_init
else there would be a lot of code repetition and possibly udefined behavior
at the driver layer.

And also why take a different path than the rest of the rte subsystems?

>
>> >This commit introduce the API that is needed by the RegEx devices in
>> >order to work with the RegEX lib.
>> >
>> >During the probe of a RegEx device, the device should configure
>itself,
>> >and allocate the resources it requires.
>> >On completion of the device init, it should call the
>> >rte_regex_dev_register in order to register itself as a RegEx device.
>> >
>> >Signed-off-by: Ori Kam <orika at mellanox.com>
>> >Signed-off-by: Parav Pandit <parav at mellanox.com>
>> >---
>> > config/common_base                        |  3 +-
>> > config/meson.build                        |  1 +
>> > lib/librte_regexdev/Makefile              |  1 +
>> > lib/librte_regexdev/meson.build           |  5 ++-
>> > lib/librte_regexdev/rte_regexdev.c        | 74
>> >++++++++++++++++++++++++++++++-
>> > lib/librte_regexdev/rte_regexdev.h        |  7 +++
>> > lib/librte_regexdev/rte_regexdev_core.h   |  2 +
>> > lib/librte_regexdev/rte_regexdev_driver.h | 50
>> >+++++++++++++++++++++
>> > meson_options.txt                         |  2 +
>> > 9 files changed, 142 insertions(+), 3 deletions(-)
>> > create mode 100644 lib/librte_regexdev/rte_regexdev_driver.h
>> >
>>
>> <snip>