[dpdk-dev] [EXT] [PATCH v1 3/4] regexdev: add regexdev core functions

[Ori Kam]

Hi Guy,
Thanks for your review

> -----Original Message-----
> From: dev <dev-bounces at dpdk.org> On Behalf Of Guy Kaneti
> Sent: Tuesday, April 7, 2020 5:22 PM
> To: Ori Kam <orika at mellanox.com>; Jerin Jacob <jerinjacobk at gmail.com>;
> Thomas Monjalon <thomas at monjalon.net>
> Cc: Jerin Jacob Kollanukkaran <jerinj at marvell.com>; xiang.w.wang at intel.com;
> Pavan Nikhilesh Bhagavatula <pbhagavatula at marvell.com>; dev at dpdk.org;
> Shahaf Shuler <shahafs at mellanox.com>; hemant.agrawal at nxp.com; Opher
> Reviv <opher at mellanox.com>; Alex Rosenbaum <alexr at mellanox.com>;
> Dovrat Zifroni <dovrat at marvell.com>; Prasun Kapoor
> <pkapoor at marvell.com>; nipun.gupta at nxp.com; bruce.richardson at intel.com;
> yang.a.hong at intel.com; harry.chang at intel.com; gu.jian1 at zte.com.cn;
> shanjiangh at chinatelecom.cn; zhangy.yun at chinatelecom.cn;
> lixingfu at huachentel.com; wushuai at inspur.com; yuyingxia at yxlink.com;
> fanchenggang at sunyainfo.com; davidfgao at tencent.com;
> liuzhong1 at chinaunicom.cn; zhaoyong11 at huawei.com; oc at yunify.com;
> jim at netgate.com; hongjun.ni at intel.com; j.bromhead at titan-ic.com;
> deri at ntop.org; fc at napatech.com; arthur.su at lionic.com; Parav Pandit
> <parav at mellanox.com>
> Subject: Re: [dpdk-dev] [EXT] [PATCH v1 3/4] regexdev: add regexdev core
> functions
> 
> Hi Ori,
> 
> >+int
> >+rte_regexdev_register(struct rte_regexdev *dev)
> >+{
> >+	uint16_t dev_id;
> >+	int res;
> >+
> >+	if (dev->dev_ops == NULL) {
> >+		RTE_REGEXDEV_LOG(ERR, "RegEx device invalid device
> ops\n");
> >+		return -EINVAL;
> >+	}
> >+	if (regexdev_allocated(dev->dev_name) != NULL) {
> >+		RTE_REGEXDEV_LOG
> >+			(ERR, "RegEx device with name %s already
> allocated\n",
> >+			 dev->dev_name);
> >+		return -ENOMEM;
> >+	}
> >+	dev_id = regexdev_find_free_dev();
> >+	if (dev_id == RTE_MAX_REGEXDEV_DEVS) {
> >+		RTE_REGEXDEV_LOG
> >+			(ERR, "Reached maximum number of regex devs\n");
> >+		return -ENOMEM;
> >+	}
> >+	dev->dev_id = dev_id;
> 
> dev is of type struct rte_regexdev *, but I don't see in the definition of struct
> rte_regexdev a field dev_id
> 

The definition of rte_regexdev appears in rte_regecdev_core.h
and the last member in this struct is the dev_id. (line146) it is added in this 
commit.

> >+	regex_devices[dev_id] = dev;
> >+	res = dev_id;
> >+	return res;
> >+}