[dpdk-dev] [PATCH v3] test: remove meson dependency on /proc file

Aaron Conole aconole at redhat.com
Fri Apr 10 16:05:00 CEST 2020


Thomas Monjalon <thomas at monjalon.net> writes:

> Meson is detecting the path /proc/sys/vm/nr_hugepages in the call to cat
> in app/test/meson.build and then adding it as a build dependency.
> This causes build loop if the timestamp of this file keeps changing.
>
> It is fixed by hiding hugepage check in a shell script.
>
> Fixes: 77784ef0fba8 ("test: allow no-huge mode for fast-tests")
>
> Signed-off-by: Thomas Monjalon <thomas at monjalon.net>
> Tested-by: Lukasz Wojciechowski <l.wojciechow at partner.samsung.com>
> Reviewed-by: Lukasz Wojciechowski <l.wojciechow at partner.samsung.com>
> Acked-by: Aaron Conole <aconole at redhat.com>
> Reviewed-by: Ruifeng Wang <ruifeng.wang at arm.com>
> ---
>
> v2: use variable as pointed by Lukasz
> v3: avoid TOCTOU issue as suggested by David
> 	I'm afraid it requires to re-confirm every reviews above.

Still looks good to me.



More information about the dev mailing list