[dpdk-dev] [PATCH] net/mlx5: use open/read/close for reading ib stat

Slava Ovsiienko viacheslavo at mellanox.com
Mon Apr 13 12:48:11 CEST 2020


> -----Original Message-----
> From: dev <dev-bounces at dpdk.org> On Behalf Of Alexander Kozyrev
> Sent: Friday, April 10, 2020 1:21
> To: Mohsin Shaikh <mohsinshaikh at niometrics.com>; dev at dpdk.org
> Cc: stable at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] net/mlx5: use open/read/close for reading ib
> stat
> 
> > -----Original Message-----
> > From: Mohsin Shaikh <mohsinshaikh at niometrics.com>
> > Sent: Thursday, April 9, 2020 16:37
> > To: dev at dpdk.org
> > Cc: stable at dpdk.org; Alexander Kozyrev <akozyrev at mellanox.com>;
> Mohsin
> > Shaikh <mohsinshaikh at niometrics.com>
> > Subject: [PATCH] net/mlx5: use open/read/close for reading ib stat
> >
> > fgets(3)/fread(3)/fscanf(3) etc. use mmap(2)/munmap(2) which leads to
> > TLB shootdown interrupts to all dpdk app cores including RX cores.
> > This can cause packet drops. Use read(2)/write(2) instead.
> >
> > Bugzilla ID: 440
> > Cc: stable at dpdk.org
> >
> > Signed-off-by: Mohsin Shaikh <mohsinshaikh at niometrics.com>
> > ---
> 
> Reviewed-by: Alexander Kozyrev <akozyrev at mellanox.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo at mellanox.com>

Thank you, Mohsin for the patch.
Alexander, thank you for the review and test.

With best regards,
Slava



More information about the dev mailing list