[dpdk-dev] [PATCH v3 01/11] net/igc: add igc PMD

Stephen Hemminger stephen at networkplumber.org
Mon Apr 13 17:19:31 CEST 2020


On Mon, 13 Apr 2020 14:30:27 +0800
alvinx.zhang at intel.com wrote:

> +	if (dev->data->mac_addrs == NULL) {
> +		PMD_INIT_LOG(ERR, "Failed to allocate %d bytes needed to "
> +				"store MAC addresses", RTE_ETHER_ADDR_LEN);

Stylistic note.
Please don't break messages across multiple lines, it makes it harder to
read, and also harder for users to search for error messages.

If you are concerned about checkpatch, checkpatch allows long lines for
messages.

		PMD_INIT_LOG(ERR,
			     "Failed allocation for MAC address");


More information about the dev mailing list