[dpdk-dev] [PATCH v4 2/2] test/crypto: Add AES-256 DOCSIS test vectors
Thomas Monjalon
thomas at monjalon.net
Tue Apr 14 11:06:52 CEST 2020
14/04/2020 10:49, De Lara Guarch, Pablo:
> From: Thomas Monjalon
> > 10/04/2020 17:03, Mairtin o Loingsigh:
> > > This patch adds test vectors for AES-256 and sets AESNI-MB as the
> > > target PMD
> >
> > There is really something wrong in the cryptodev API.
> > Why the PMD must be selected in the tests?
> > Isn't there some capabilities in cryptodev?
> > Whitelisting PMD in the test prevents testing capabilities API.
> >
> > It looks the required refactoring is not progressing enough.
> > I suggest blocking all crypto-related patches until is is fixed.
> >
>
> You are right, but Mairtin was following the same approach as it was taken previously.
I know. His patch was accepted.
> I agree that this approach is not the best one and we are currently working
> on a better solution.
Now that's clear, let's not merge any new crypto patch until
the capabilities are working and tested.
More information about the dev
mailing list