[dpdk-dev] [PATCH v3 05/10] eal: introduce internal wrappers for file operations

Thomas Monjalon thomas at monjalon.net
Wed Apr 15 23:48:33 CEST 2020


Thanks for starting the new directory for Unix common implementation.

14/04/2020 21:44, Dmitry Kozlyuk:
> --- /dev/null
> +++ b/lib/librte_eal/unix/eal.c

Please take care of not creating a new file without adding
SPDX tag and copyright owner.

> @@ -0,0 +1,47 @@
> +#include <sys/file.h>
> +#include <sys/mman.h>
> +#include <unistd.h>
> +
> +#include <rte_errno.h>
> +
> +#include "eal_private.h"
> +
> +int
> +eal_file_truncate(int fd, ssize_t size)
[...]
> +int
> +eal_file_lock(int fd, enum eal_flock_op op, enum eal_flock_mode mode)

+1
Adding new abstractions is the way to go in my opinion.
Thanks




More information about the dev mailing list