[dpdk-dev] [PATCH v8 1/6] lib/eal: implement the family of common bit operation APIs

Jerin Jacob jerinjacobk at gmail.com
Fri Apr 17 11:38:32 CEST 2020


On Thu, Apr 16, 2020 at 11:09 AM Joyce Kong <joyce.kong at arm.com> wrote:
>
> Bitwise operation APIs are defined and used in a lot of PMDs,
> which caused a huge code duplication. To reduce duplication,
> this patch consolidates them into a common API family.
>
> Signed-off-by: Joyce Kong <joyce.kong at arm.com>
> Reviewed-by: Gavin Hu <gavin.hu at arm.com>
> Reviewed-by: Phil Yang <phil.yang at arm.com>
> Acked-by: Morten Brørup <mb at smartsharesystems.com>
> ---
>  MAINTAINERS                         |   4 +
>  doc/api/doxy-api-index.md           |   5 +-
>  lib/librte_eal/include/meson.build  |   1 +
>  lib/librte_eal/include/rte_bitops.h | 258 ++++++++++++++++++++++++++++
>  4 files changed, 266 insertions(+), 2 deletions(-)
>  create mode 100644 lib/librte_eal/include/rte_bitops.h
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 4800f6884..1d5fad28b 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -241,6 +241,10 @@ M: Cristian Dumitrescu <cristian.dumitrescu at intel.com>
>  F: lib/librte_eal/include/rte_bitmap.h
>  F: app/test/test_bitmap.c
>
> +Bitops
> +M: Joyce Kong <joyce.kong at arm.com>
> +F: lib/librte_eal/include/rte_bitops.h
> +
>  MCSlock - EXPERIMENTAL
>  M: Phil Yang <phil.yang at arm.com>
>  F: lib/librte_eal/include/generic/rte_mcslock.h
> diff --git a/doc/api/doxy-api-index.md b/doc/api/doxy-api-index.md
> index dff496be0..b63e782ec 100644
> --- a/doc/api/doxy-api-index.md
> +++ b/doc/api/doxy-api-index.md
> @@ -9,6 +9,7 @@ API {#index}
>  The public API headers are grouped by topics:
>
>  - **device**:
> +  [bitops]             (@ref rte_bitops.h),

IMO, It may not come in "device" section, instead  existing "**basic**
section is more appropriate.


More information about the dev mailing list