[dpdk-dev] [PATCH v5] build: disable experimental API check internally

[Trahe, Fiona]

Hi David,

> -----Original Message-----
> From: David Marchand <david.marchand at redhat.com>
> Sent: Friday, April 17, 2020 2:23 PM
> To: Trahe, Fiona <fiona.trahe at intel.com>
> Cc: dev <dev at dpdk.org>; Jerin Jacob <jerinjacobk at gmail.com>; Pavan Nikhilesh
> <pbhagavatula at marvell.com>; Richardson, Bruce <bruce.richardson at intel.com>; Thomas Monjalon
> <thomas at monjalon.net>; Yigit, Ferruh <ferruh.yigit at intel.com>; Hemant Agrawal
> <hemant.agrawal at nxp.com>
> Subject: Re: [dpdk-dev] [PATCH v5] build: disable experimental API check internally
> 
> On Fri, Apr 17, 2020 at 12:21 PM Trahe, Fiona <fiona.trahe at intel.com> wrote:
> > I see this is already applied.
> >
> > However,
> > rte_cryptodev_queue_pair_setup() calls
> > rte_cryptodev_sym_get_existing_header_session_size()
> > The former is a stable API, the latter is experimental.
> > So I expect the build to break when ALLOW_EXPERIMENTAL_API is disabled.
[Fiona] Thanks for confirming where the flag is.
But I think you've missed my point.
What about this problem?
How was this tested with the flag disabled?


> > I tried to build the crypto_perf tool to check this, wasn't clear where it gets it, seems like it inherits
> from here:
> > mk/target/generic/rte.vars.mk. So I disabled it there and got many build errors.
> 
> I suppose you mean dpdk-test-crypto-perf.
> This tool is compiled inside dpdk, so the flag is inherited from
> rte.vars.mk as intended.
> 
> 
> --
> David Marchand