[dpdk-dev] [PATCH 3/3] net/ice: add flow support for AH ESP and L2TP

[Zhao1, Wei]

Ok， fix in v2

> -----Original Message-----
> From: Zhang, Qi Z <qi.z.zhang at intel.com>
> Sent: Monday, April 20, 2020 1:17 PM
> To: Zhao1, Wei <wei.zhao1 at intel.com>; dev at dpdk.org
> Cc: Fu, Qi <qi.fu at intel.com>
> Subject: RE: [PATCH 3/3] net/ice: add flow support for AH ESP and L2TP
> 
> 
> 
> > -----Original Message-----
> > From: Zhao1, Wei <wei.zhao1 at intel.com>
> > Sent: Friday, April 17, 2020 4:26 PM
> > To: dev at dpdk.org
> > Cc: Zhang, Qi Z <qi.z.zhang at intel.com>; Fu, Qi <qi.fu at intel.com>;
> > Zhao1, Wei <wei.zhao1 at intel.com>
> > Subject: [PATCH 3/3] net/ice: add flow support for AH ESP and L2TP
> >
> > Add switch filter support for AH ESP and L2TP protocol, and use spi or
> > session idas input set for switch rule.
> >
> > Signed-off-by: Wei Zhao <wei.zhao1 at intel.com>
> > ---
> .....
> 
> >  struct sw_meta {
> >  	struct ice_adv_lkup_elem *list;
> > @@ -148,16 +166,24 @@ ice_pattern_match_item
> > ice_switch_pattern_dist_comms[] = {
> >  			ICE_SW_INSET_MAC_PPPOE_PROTO, ICE_INSET_NONE},
> >  	{pattern_eth_vlan_pppoes_proto,
> >  			ICE_SW_INSET_MAC_PPPOE_PROTO, ICE_INSET_NONE},
> > +	{pattern_eth_ipv4_esp,
> > +			ICE_SW_INSET_MAC_IPV4_ESP, ICE_INSET_NONE},
> > +	{pattern_eth_ipv4_udp_esp,
> > +			ICE_SW_INSET_MAC_IPV6_ESP, ICE_INSET_NONE},
> 
> Why IPv6 input be used by IPv4 flow? Just typo?
> 
> >  	{pattern_eth_ipv6_esp,
> > -			ICE_INSET_NONE, ICE_INSET_NONE},
> > +			ICE_SW_INSET_MAC_IPV4_ESP, ICE_INSET_NONE},
> 
> Same issue.
> 
>