[dpdk-dev] [PATCH v9 2/2] eal: support for VFIO-PCI VF token

[Wang, Haiyue]

> -----Original Message-----
> From: Thomas Monjalon <thomas at monjalon.net>
> Sent: Wednesday, April 22, 2020 16:24
> To: Wang, Haiyue <haiyue.wang at intel.com>
> Cc: dev at dpdk.org; Burakov, Anatoly <anatoly.burakov at intel.com>; vattunuru at marvell.com;
> jerinj at marvell.com; alex.williamson at redhat.com; david.marchand at redhat.com
> Subject: Re: [PATCH v9 2/2] eal: support for VFIO-PCI VF token
> 
> 22/04/2020 07:08, Haiyue Wang:
> > --- a/devtools/libabigail.abignore
> > +++ b/devtools/libabigail.abignore
> > +[suppress_function]
> > +	name = rte_vfio_setup_device
> 
> There is no comment to justify ignoring this symbol.
> 
> The current policy is to reject any change in libabigail.abignore
> which could be better handled with (unfinished) rte_internal mark.
> 
> 

While updating the vfio patch, also doing the ABI things. Found that:
1). [suppress_function]
	name = rte_vfio_setup_device
    can make CI happy, but not scale.

2). rte_internal is beautiful, but make CI cry : https://patchwork.dpdk.org/patch/69109/
1 Removed function:

  [D] 'function int rte_vfio_setup_device(const char*, const char*, int*, vfio_device_info*)'    {rte_vfio_setup_device@@DPDK_20.0}