[dpdk-dev] [PATCH] security: fix crash at accessing non-implemented ops
Konstantin Ananyev
konstantin.ananyev at intel.com
Thu Apr 23 01:51:58 CEST 2020
Valid checks for optional function pointers inside dev-ops
were disabled by undefined macro.
Fixes: b6ee98547847 ("security: fix verification of parameters")
Signed-off-by: Konstantin Ananyev <konstantin.ananyev at intel.com>
---
lib/librte_security/rte_security.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/lib/librte_security/rte_security.c b/lib/librte_security/rte_security.c
index d475b0977..b65430ce2 100644
--- a/lib/librte_security/rte_security.c
+++ b/lib/librte_security/rte_security.c
@@ -107,11 +107,9 @@ rte_security_set_pkt_metadata(struct rte_security_ctx *instance,
struct rte_security_session *sess,
struct rte_mbuf *m, void *params)
{
-#ifdef RTE_DEBUG
RTE_PTR_CHAIN3_OR_ERR_RET(instance, ops, set_pkt_metadata, -EINVAL,
-ENOTSUP);
RTE_PTR_OR_ERR_RET(sess, -EINVAL);
-#endif
return instance->ops->set_pkt_metadata(instance->device,
sess, m, params);
}
@@ -121,9 +119,7 @@ rte_security_get_userdata(struct rte_security_ctx *instance, uint64_t md)
{
void *userdata = NULL;
-#ifdef RTE_DEBUG
RTE_PTR_CHAIN3_OR_ERR_RET(instance, ops, get_userdata, NULL, NULL);
-#endif
if (instance->ops->get_userdata(instance->device, md, &userdata))
return NULL;
--
2.17.1
More information about the dev
mailing list