[dpdk-dev] [PATCH v4] lpm: skip table entries update if rules found
Thomas Monjalon
thomas at monjalon.net
Fri Apr 24 19:17:30 CEST 2020
21/04/2020 17:44, Medvedkin, Vladimir:
> Hi Yangchao,
>
> Thanks for the patch.
> This might be useful for control plane implementations that don't track
> inserted routes.
> I have just a one nit inlined below. Also, could you do the same for lpm6?
>
> P.S. Please have a look at rte_fib library, there are more optimizations
> compared to lpm library.
>
> Apart from that,
> Acked-by: Vladimir Medvedkin <vladimir.medvedkin at intel.com>
[...]
> > /* If rule already exists update its next_hop and return. */
Reduced length of above comment,
> > if (lpm->rules_tbl[rule_index].ip == ip_masked) {
> > +
> > + if (lpm->rules_tbl[rule_index].next_hop == next_hop)
>
>
> Line over 80 characters, please split it by two.
and split above line.
Applied with requested changes, thanks.
More information about the dev
mailing list