[dpdk-dev] [PATCH v3 0/4] Enforce checking on flag values in API's
Bruce Richardson
bruce.richardson at intel.com
Tue Apr 28 12:28:25 CEST 2020
On Mon, Apr 27, 2020 at 04:16:21PM -0700, Stephen Hemminger wrote:
> The DPDK API's are lax about checking for undefined flag values.
> This makes it impossible to add new bits to existing API's
> without causing ABI breakage. This means we end up doing unnecessary
> symbol versioning just to work around applications that might
> pass in naughty bits.
>
> This is the DPDK analog of the Linux kernel openat() problem.
> Openat api was added but since kernel did not check flags it
> ended up that another syscall openat2() was necessary before
> the flags could be used.
>
> v3 - define mask based on existing defines for ring and hash
>
> Stephen Hemminger (4):
> ring: future proof flag settings
> hash: check flags on creation
> stack: check flags on creation
> cfgfile: check flags value
>
> lib/librte_cfgfile/rte_cfgfile.c | 4 ++++
> lib/librte_hash/rte_cuckoo_hash.c | 14 ++++++++++++++
> lib/librte_ring/rte_ring.c | 12 ++++++++++++
> lib/librte_stack/rte_stack.c | 5 +++++
> 4 files changed, 35 insertions(+)
>
I think this is a good idea to do in DPDK
Series-acked-by: Bruce Richardson <bruce.richardson at intel.com>
More information about the dev
mailing list