[dpdk-dev] [PATCH v3 05/10] eal: introduce internal wrappers for file operations

Dmitry Kozlyuk dmitry.kozliuk at gmail.com
Wed Apr 29 01:50:52 CEST 2020


On 2020-04-17 13:24 GMT+0100 Burakov, Anatoly wrote:
[snip]
> > +/** Behavior on file locking conflict. */
> > +enum eal_flock_mode {
> > +	EAL_FLOCK_WAIT,  /**< Wait until the file gets unlocked to lock it. */
> > +	EAL_FLOCK_RETURN /**< Return immediately if the file is locked. */
> > +};  
> 
> Nitpicking, but why not blocking/unblocking? The terminology seems 
> pretty standard.

On Windows, LockFileEx() call may be non-blocking, but still configured to
fail if the lock is already taken. To avoid confusion, these names reflect
what the behavior will be instead of how it will be achieved.

-- 
Dmitry Kozlyuk


More information about the dev mailing list