[dpdk-dev] [PATCH] tracepoint: fix compilation with C++

David Marchand david.marchand at redhat.com
Wed Aug 5 10:00:07 CEST 2020


Hello Pawel,

Thanks for contributing to DPDK.


On Tue, Aug 4, 2020 at 7:52 PM Pawel Wodkowski <pawelwod at gmail.com> wrote:
>
> trace_mem is declared as 'void *' which triggers following error:
> '...invalid conversion from ‘void*’ to ‘__rte_trace_header*’
> [-fpermissive]...'
>
> Fix this by changing void to struct __rte_trace_header

I Cc'd trace maintainers.
For subsequent revisions, you can do directly Cc them by calling the
get-maintainer.sh script like this:
$ git send-email --to dev at dpdk.org --cc-cmd devtools/get-maintainer.sh $patch


On the form of the patch, this patch is missing a signed-off tag,
please have a look at the contribution guidelines:
https://doc.dpdk.org/guides/contributing/patches.html
Do not forget to chain replies using the --in-reply-to option for git
send-email.

This is a fix, so we expect a Fixes: tag in the commitlog.
This tag should point at the original commit that introduced the issue.


Looking at the CI report
http://mails.dpdk.org/archives/test-report/2020-August/147927.html,
you will see that the windows part is missing an update.

$ git grep -wl trace_mem
lib/librte_eal/common/eal_common_trace.c
lib/librte_eal/include/rte_trace_point.h
lib/librte_eal/windows/eal.c


-- 
David Marchand



More information about the dev mailing list