[dpdk-dev] [PATCH] net/ice: fix incorrect firmware version

Yang, Qiming qiming.yang at intel.com
Thu Aug 6 11:15:53 CEST 2020



> -----Original Message-----
> From: Wang, ShougangX <shougangx.wang at intel.com>
> Sent: Thursday, August 6, 2020 16:25
> To: dev at dpdk.org
> Cc: Yang, Qiming <qiming.yang at intel.com>; Zhang, Qi Z
> <qi.z.zhang at intel.com>; Wang, ShougangX <shougangx.wang at intel.com>;
> stable at dpdk.org
> Subject: [PATCH] net/ice: fix incorrect firmware version
> 
> Kernel driver shows firmware version as hex but ice PMD shows as decimal.
> This patch fixes the issue to make consistent with kernel driver.
> 
> Fixes: ac882a0eda69 ("net/ice/base: store NVM version in extracted format")

Fix line not correct, should be the code you fixed

> Cc: stable at dpdk.org
> 
> Signed-off-by: Shougang Wang <shougangx.wang at intel.com>
> ---
>  drivers/net/ice/ice_ethdev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
> index 8d435e889..88b8428b9 100644
> --- a/drivers/net/ice/ice_ethdev.c
> +++ b/drivers/net/ice/ice_ethdev.c
> @@ -4388,7 +4388,7 @@ ice_fw_version_get(struct rte_eth_dev *dev, char
> *fw_version, size_t fw_size)
>  	build = hw->nvm.orom.build;
> 
>  	ret = snprintf(fw_version, fw_size,
> -			"%d.%d 0x%08x %d.%d.%d",
> +			"%x.%02x 0x%08x %d.%d.%d",
>  			hw->nvm.major_ver,
>  			hw->nvm.minor_ver,
>  			hw->nvm.eetrack,
> --
> 2.17.1



More information about the dev mailing list