[dpdk-dev] [PATCH] doc: scheduler API deprecation notice

Trahe, Fiona fiona.trahe at intel.com
Mon Aug 10 13:49:32 CEST 2020


Sorry about that Thomas, Akhil, we should have chased up acks sooner. 

Given the proposed content of the patch, and the similar changes that are recommended and agreed
throughout DPDK do you think an exception can be made and that this change can get into 20.11 even
without the deprecation notice being in 20.08?
 

> -----Original Message-----
> From: Thomas Monjalon <thomas at monjalon.net>
> Sent: Monday, August 10, 2020 11:19 AM
> To: Dybkowski, AdamX <adamx.dybkowski at intel.com>
> Cc: dev at dpdk.org; Trahe, Fiona <fiona.trahe at intel.com>; Zhang, Roy Fan <roy.fan.zhang at intel.com>;
> stephen at networkplumber.org; Burakov, Anatoly <anatoly.burakov at intel.com>; bluca at debian.org;
> Akhil Goyal <akhil.goyal at nxp.com>; Richardson, Bruce <bruce.richardson at intel.com>; Mcnamara, John
> <john.mcnamara at intel.com>
> Subject: Re: [dpdk-dev] [PATCH] doc: scheduler API deprecation notice
> 
> 10/08/2020 11:47, Dybkowski, AdamX:
> > I see there are 3 ACKs: original (see the commit message) from Fan, then Thomas and Akhil.
> > This page: http://patches.dpdk.org/project/dpdk/list/?series=11317
> > also shows it has 3 ACKs.
> 
> Sorry I missed initial ack.
> 
> > Can I ask why it didn't go into 20.08 then?
> 
> Because it was completed late, I missed and nobody replied.
> 
> In general, I would like more support in last days of release,
> to avoid such miss.
> 
> 
> > From: Thomas Monjalon <thomas at monjalon.net>
> > > 06/08/2020 19:18, Akhil Goyal:
> > > > > 27/07/2020 11:41, Adam Dybkowski:
> > > > > > This patch adds a deprecation notice about upcoming changes in
> > > > > > public API of the Scheduler PMD.
> > > > > >
> > > > > > Signed-off-by: Adam Dybkowski <adamx.dybkowski at intel.com>
> > > > > > Acked-by: Fan Zhang <roy.fan.zhang at intel.com>
> > > > > > ---
> > > > > > +* scheduler: The functions
> > > > > > +``rte_cryptodev_scheduler_slave_attach``,
> > > > > > +  ``rte_cryptodev_scheduler_slave_detach`` and
> > > > > > +  ``rte_cryptodev_scheduler_slaves_get`` will be replaced in
> > > > > > +20.11 by
> > > > > > +  ``rte_cryptodev_scheduler_worker_attach``,
> > > > > > +  ``rte_cryptodev_scheduler_worker_detach`` and
> > > > > > +  ``rte_cryptodev_scheduler_workers_get`` accordingly.
> > > > >
> > > > > Acked-by: Thomas Monjalon <thomas at monjalon.net>
> > > > >
> > > > I wonder how this patch got missed.
> > > >
> > > > Acked-by: Akhil Goyal <akhil.goyal at nxp.com>
> > >
> > > Sorry it is missing an ack.
> 
> 



More information about the dev mailing list