[dpdk-dev] [PATCH v3] doc: add section describing new abi versions

Kinsella, Ray mdr at ashroe.eu
Wed Aug 12 13:19:44 CEST 2020


v4 on the way, other notes are below. 

On 12/08/2020 11:40, Thomas Monjalon wrote:
[SNIP]

>>  Experimental
>>  ------------
>>
>> +Major ABI versions are usually but not always declared aligned with a
>> +:ref:`LTS release <stable_lts_releases>`.
> 
> Why adding this sentence here?
Will remove.

> 
> 
>> +
>>  APIs
>>  ~~~~
>>
>> diff --git a/doc/guides/contributing/abi_versioning.rst b/doc/guides/contributing/abi_versioning.rst
>> index b1d09c7..3d35b1a 100644
>> --- a/doc/guides/contributing/abi_versioning.rst
>> +++ b/doc/guides/contributing/abi_versioning.rst
>> @@ -673,9 +673,9 @@ symbols.
>>   -BIND_DEFAULT_SYMBOL(rte_acl_create, _v20, 20);
>>   +BIND_DEFAULT_SYMBOL(rte_acl_create, _v21, 21);
> 
> Why updating the version here? A lot of examples are given with v20.

I didn't change this then - and + are in the documentation. 

> 
> 
>> -Lastly, any VERSION_SYMBOL macros that point to the old version node should be
>> -removed, taking care to keep, where need old code in place to support newer
>> -versions of the symbol.
>> +Lastly, any VERSION_SYMBOL macros that point to the old version nodes should be
>> +removed, taking care to preserve any code that is shared with the new version
>> +node.
> 
> 
> 


More information about the dev mailing list