[dpdk-dev] [PATCH 20.11 01/19] examples: remove legacy sections of makefiles

Bruce Richardson bruce.richardson at intel.com
Fri Aug 14 12:29:28 CEST 2020


On Fri, Aug 07, 2020 at 01:29:51PM +0100, Ciara Power wrote:
> The example app makefiles contained sections using the legacy method of
> compiling with make. These are no longer needed, and are removed,
> leaving only the section that uses pkg-config for the make build.
> 
> Signed-off-by: Ciara Power <ciara.power at intel.com>
> ---
>  examples/bbdev_app/Makefile             | 23 ++-------------
<snip>
>  examples/vmdq/Makefile                  | 23 ++-------------
>  examples/vmdq_dcb/Makefile              | 31 ++------------------
>  43 files changed, 129 insertions(+), 1078 deletions(-)
> 
> diff --git a/examples/bbdev_app/Makefile b/examples/bbdev_app/Makefile
> index 3c8eb75a4e..9675c6d096 100644
> --- a/examples/bbdev_app/Makefile
> +++ b/examples/bbdev_app/Makefile
> @@ -8,7 +8,9 @@ APP = bbdev
>  SRCS-y := main.c
>  
>  # Build using pkg-config variables if possible
> -ifeq ($(shell pkg-config --exists libdpdk && echo 0),0)
> +ifneq ($(shell pkg-config --exists libdpdk && echo 0),0)
> +	$(error "no installation of DPDK found")
> +endif
>  
Unfortunately make is whitespace sensitive, so you can't indent here
without getting a syntax error in the case that dpdk is not installed.
Instead of the error message you get e.g.:

	Makefile:12: *** recipe commences before first target.  Stop.

This applies to all makefiles in this patch, I think.

/Bruce


More information about the dev mailing list