[dpdk-dev] [PATCH v2] windows/netuio: add Windows NetUIO kernel driver

[Ranjit Menon]

Hi, Naty

On 8/20/2020 3:23 PM, Narcisa Ana Maria Vasile wrote:
> From: Narcisa Vasile <navasile at microsoft.com>
>
> The Windows NetUIO kernel driver allows the DPDK userspace
> application to directly access the hardware.
>
> Cc: Harini Ramakrishnan <Harini.Ramakrishnan at microsoft.com>
> Cc: Omar Cardona <ocardona at microsoft.com>
> Signed-off-by: Narcisa Vasile <navasile at microsoft.com>
> ---
>
> v2:
>    Fix license message in each file
>    Minor fixes in README
>    Remove RC file as it is autogenerated
>    Remove HW Ids from Inf
>    Resubmit as single patch
>
>   .gitattributes                                |   4 +
>   .gitignore                                    |   2 +
>   windows/netuio/kernel/README_NetUIO.rst       |  64 +++
>   .../netuio/kernel/windows/netuio/netuio.inf   |  78 ++++
>   .../netuio/kernel/windows/netuio/netuio_dev.c | 388 +++++++++++++++++
>   .../netuio/kernel/windows/netuio/netuio_dev.h |  61 +++
>   .../netuio/kernel/windows/netuio/netuio_drv.c | 146 +++++++
>   .../netuio/kernel/windows/netuio/netuio_drv.h |  32 ++
>   .../kernel/windows/netuio/netuio_interface.h  |  73 ++++
>   .../kernel/windows/netuio/netuio_queue.c      | 397 ++++++++++++++++++
>   .../kernel/windows/netuio/netuio_queue.h      |  31 ++
>   .../netuio/kernel/windows/netuio/resource.h   |  14 +
>   .../mk/exec-env/windows/netuio/netuio.sln     |  24 ++
>   .../mk/exec-env/windows/netuio/netuio.vcxproj | 113 +++++
>   .../windows/netuio/netuio.vcxproj.filters     |  54 +++
>   .../windows/netuio/netuio.vcxproj.user        |  11 +
>   16 files changed, 1492 insertions(+)
>   create mode 100644 .gitattributes
>   create mode 100644 .gitignore
>   create mode 100644 windows/netuio/kernel/README_NetUIO.rst
>   create mode 100644 windows/netuio/kernel/windows/netuio/netuio.inf
>   create mode 100644 windows/netuio/kernel/windows/netuio/netuio_dev.c
>   create mode 100644 windows/netuio/kernel/windows/netuio/netuio_dev.h
>   create mode 100644 windows/netuio/kernel/windows/netuio/netuio_drv.c
>   create mode 100644 windows/netuio/kernel/windows/netuio/netuio_drv.h
>   create mode 100644 windows/netuio/kernel/windows/netuio/netuio_interface.h
>   create mode 100644 windows/netuio/kernel/windows/netuio/netuio_queue.c
>   create mode 100644 windows/netuio/kernel/windows/netuio/netuio_queue.h
>   create mode 100644 windows/netuio/kernel/windows/netuio/resource.h
>   create mode 100644 windows/netuio/mk/exec-env/windows/netuio/netuio.sln
>   create mode 100644 windows/netuio/mk/exec-env/windows/netuio/netuio.vcxproj
>   create mode 100644 windows/netuio/mk/exec-env/windows/netuio/netuio.vcxproj.filters
>   create mode 100644 windows/netuio/mk/exec-env/windows/netuio/netuio.vcxproj.user

I haven't reviewed the code yet, but a few general suggestions and 
observations:

1. This code is going into the dpdk-kmods repo, so we don't need the 
four-level deep directory path for the source.

2. The code can simply be in the windows/netuio directory (don't need 
'kernel')

3. The 'virt2phys' module that is already in the repo puts the 
build-related files (project files, solution files etc) in the same 
folder as the source files. We should do the same here. We don't need 
the mk/exec-env subfolder for these files. They can be in the same 
directory as the source.

4. Remove the .vcxproj.user file from the patch. It is not required.

5. The README should be renamed to simply README.rst and it can also be 
in this windows/netuio folder

6. The existing README.rst in the windows folder contains information on 
how to build and load kernel modules in Windows. This new README can 
reference the root-level README, if required. (Also some of the 
information in this new README is out-of-date. I'll review that separately)


ranjit m.