[dpdk-dev] [PATCH v5] devtools: add new SPDX license compliance checker

Bruce Richardson bruce.richardson at intel.com
Wed Aug 26 17:43:37 CEST 2020


On Wed, Aug 26, 2020 at 08:12:30AM -0700, Stephen Hemminger wrote:
> On Fri, 31 Jul 2020 00:06:23 +0200
> Thomas Monjalon <thomas at monjalon.net> wrote:
> 
> > 15/07/2020 01:21, Stephen Hemminger:
> > > Simple script to look for drivers and scripts that
> > > are missing requires SPDX header.
> > > 
> > > Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>  
> > [...]
> > > +#! /bin/sh
> > > +# SPDX-License-Identifier: BSD-3-Clause
> > > +# Copyright 2020 Microsoft Corporation
> > > +#
> > > +# Produce a list of files with incorrect license tags
> > > +
> > > +errors=0
> > > +warnings=0
> > > +quiet=false
> > > +verbose=false
> > > +
> > > +print_usage () {
> > > +    echo "usage: $(basename $0) [-q] [-v]"
> > > +    exit 1
> > > +}
> > > +
> > > +check_spdx() {
> > > +    if  $verbose;  then
> > > +	echo "Files without SPDX License"
> > > +	echo "--------------------------"
> > > +    fi
> > > +    git grep -L SPDX-License-Identifier -- \
> > > +	':^.git*' ':^.ci/*' ':^.travis.yml' \
> > > +	':^README' ':^MAINTAINERS' ':^VERSION' ':^ABI_VERSION' \
> > > +	':^*/Kbuild' ':^*/README' \
> > > +	':^license/' ':^config/' ':^buildtools/' \
> > > +	':^*.cocci' ':^*.abignore' \
> > > +	':^*.def' ':^*.map' ':^*.ini' ':^*.data' ':^*.cfg' ':^*.txt' \
> > > +	':^*.svg' ':^*.png'\  
> > 
> > I don't agree with this list of files.
> > But I guess we can start with that and be more strict in future.
> 
> I suppose README, MAINTAINERS, .ini and .txt files could be removed from the exception list.

We also want to scan the files in config and buildtools.


More information about the dev mailing list