[dpdk-dev] [PATCH 06/13] app/flow-perf: fix memory leak from RSS action
Wisam Jaddo
wisamm at mellanox.com
Sun Aug 30 13:15:37 CEST 2020
Currently, each call for add_rss_action will allocate
extra memory for rss_data, which will reflect bad results
on memory consumption for all flows, and will leads into
memory leak.
In this fix, it will check if it's allocated before
reallocating it.
Fixes: bf3688f1e816 ("app/flow-perf: add insertion rate calculation")
Cc: wisamm at mellanox.com
Signed-off-by: Wisam Jaddo <wisamm at mellanox.com>
Acked-by: Alexander Kozyrev <akozyrev at nvidia.com>
---
app/test-flow-perf/actions_gen.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/app/test-flow-perf/actions_gen.c b/app/test-flow-perf/actions_gen.c
index 9fe11abc94..99e47bf786 100644
--- a/app/test-flow-perf/actions_gen.c
+++ b/app/test-flow-perf/actions_gen.c
@@ -86,8 +86,9 @@ add_rss(struct rte_flow_action *actions,
uint16_t queue;
- rss_data = rte_malloc("rss_data",
- sizeof(struct action_rss_data), 0);
+ if (rss_data == NULL)
+ rss_data = rte_malloc("rss_data",
+ sizeof(struct action_rss_data), 0);
if (rss_data == NULL)
rte_exit(EXIT_FAILURE, "No Memory available!");
--
2.17.1
More information about the dev
mailing list