[dpdk-dev] [PATCH v2] windows: build warnings with clang

[Thomas Monjalon]

03/12/2020 01:02, Dmitry Kozlyuk:
> On Sun, 29 Nov 2020 16:00:24 +0000, Nick Connolly wrote:
> > Microsoft CRT defines Windows-specific secure alternatives to
> > standard library functions and triggers warnings when "insecure"
> > functions are used [1]. However, calling code already has all
> > necessary checks around those functions, so these warnings are not
> > useful for DPDK. MinGW provides its own CRT without this issue.
> > 
> > [1]:
> > https://docs.microsoft.com/en-us/cpp/c-runtime-library/security-features-in-the-crt?view=msvc-160
> > 
> > Disable this by defining -D_CRT_SECURE_NO_WARNINGS.
> > 
> > Signed-off-by: Nick Connolly <nick.connolly at mayadata.io>
> > ---
> > v2:
> > * Adjust commit wording as per Dmitry Kozlyuk <dmitry.kozliuk at gmail.com>
> > 
> > Note: It is unclear exactly which commit this fixes.  It is probably a
> > consequence of building more libraries for Windows.
> 
> Acked-by: Dmitry Kozlyuk <dmitry.kozliuk at gmail.com>

Applied, thanks