[dpdk-dev] [PATCH] net/e1000: fix incorrect return value if filter type not supported.

Wang, Haiyue haiyue.wang at intel.com
Tue Dec 8 11:40:47 CET 2020


From: haz ben <benhaz1024 at gmail.com>
Sent: Tuesday, December 8, 2020 17:58
To: Wang, Haiyue <haiyue.wang at intel.com>
Cc: ban, xiaozhen <benhaz1024 at gmail.com>; Guo, Jia <jia.guo at intel.com>; dev at dpdk.org
Subject: Re: [PATCH] net/e1000: fix incorrect return value if filter type not supported.

my name is ban, xiaozhen.

OK, ;-)

the commit message is "net/e1000: fix incorrect return value if filter type not supported." does additional details should be add?

It is not about additional, it is better for title + more descriptive message.

Wang, Haiyue <haiyue.wang at intel.com<mailto:haiyue.wang at intel.com>> 于2020年12月8日周二 下午5:04写道:
> -----Original Message-----
> From: banxiaozhen benhaz1024 at gmail.com<mailto:benhaz1024 at gmail.com> <banxiaozhen benhaz1024 at gmail.com<mailto:benhaz1024 at gmail.com>>
> Sent: Tuesday, December 8, 2020 16:10
> To: Guo, Jia <jia.guo at intel.com<mailto:jia.guo at intel.com>>; Wang, Haiyue <haiyue.wang at intel.com<mailto:haiyue.wang at intel.com>>
> Cc: dev at dpdk.org<mailto:dev at dpdk.org>; banxiaozhen <benhaz1024 at gmail.com<mailto:benhaz1024 at gmail.com>>
> Subject: [PATCH] net/e1000: fix incorrect return value if filter type not supported.
>
> From: banxiaozhen <benhaz1024 at gmail.com<mailto:benhaz1024 at gmail.com>>
>
> Signed-off-by: banxiaozhen <benhaz1024 at gmail.com<mailto:benhaz1024 at gmail.com>>

The patch looks good.

The name format should be like "Banxiao Zhen", and the commit message is empty ?

> ---
>  drivers/net/e1000/igb_ethdev.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c
> index 647aa8d99..8695426c2 100644
> --- a/drivers/net/e1000/igb_ethdev.c
> +++ b/drivers/net/e1000/igb_ethdev.c
> @@ -4561,6 +4561,7 @@ eth_igb_filter_ctrl(struct rte_eth_dev *dev __rte_unused,
>       default:
>               PMD_DRV_LOG(WARNING, "Filter type (%d) not supported",
>                                                       filter_type);
> +             ret = -EINVAL;
>               break;
>       }
>
> --
> 2.24.3 (Apple Git-128)


More information about the dev mailing list