[dpdk-dev] [PATCH] net/netvsc: ignore NVS_TYPE_TXTBL_NOTE while executing a sync command

Stephen Hemminger stephen at networkplumber.org
Fri Dec 11 18:21:36 CET 2020


On Thu, 10 Dec 2020 23:52:44 -0800
Long Li <longli at linuxonhyperv.com> wrote:

> From: Long Li <longli at microsoft.com>
> 
> On netvsc initialization, the host VSP may send a NVS_TYPE_TXTBL_NOTE packet
> while executing a VSP command synchronously.
> 
> Ignore this packet as we don't use it for DPDK.
> 
> Cc: stable at dpdk.org
> Signed-off-by: Long Li <longli at microsoft.com>
> ---
>  drivers/net/netvsc/hn_nvs.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/netvsc/hn_nvs.c b/drivers/net/netvsc/hn_nvs.c
> index a0ee7d8bfa..b6aa07cc5f 100644
> --- a/drivers/net/netvsc/hn_nvs.c
> +++ b/drivers/net/netvsc/hn_nvs.c
> @@ -97,8 +97,13 @@ __hn_nvs_execute(struct hn_data *hv,
>  	hdr = (struct hn_nvs_hdr *)buffer;
>  
>  	/* Silently drop received packets while waiting for response */
> -	if (hdr->type == NVS_TYPE_RNDIS) {
> +	switch (hdr->type) {
> +	case NVS_TYPE_RNDIS:
>  		hn_nvs_ack_rxbuf(chan, xactid);
> +		/* fallthrough */
> +
> +	case NVS_TYPE_TXTBL_NOTE:
> +		PMD_DRV_LOG(NOTICE, "discard packet type %x", hdr->type);
>  		goto retry;
>  	}
>  

Could you change that log message to DEBUG (or INFO) level?
Users probably don't need to see it.

Acked-by: Stephen Hemminger <stephen at networkplumber.org>



More information about the dev mailing list