[dpdk-dev] [PATCH v2 2/2] build: i40e PMD on Windows

[Kadam, Pallavi]

Hi Thomas,

On 12/18/2020 3:27 AM, Thomas Monjalon wrote:
> 17/12/2020 23:59, Pallavi Kadam:
>> Adds temp folder mlx5/windows as it is required to build this patch
>> without any build error. This folder will be removed once mlx5 PMD
>> patches are merged.
> Why is it required?

The patch [1] already supports Windows build for mlx5 PMD.

However, there is no Windows folder in the current main branch
and this gives following error when building with meson
after entire "net" dir is enabled:

drivers\net\mlx5\meson.build:56:0:
ERROR: Non-existent build file 'drivers\\net/mlx5\\windows\\meson.build'

  

[1]http://patches.dpdk.org/patch/70839/  <http://patches.dpdk.org/patch/70839/>

>
>> +if is_windows
>> +	build = false
>> +	reason = 'Not supported on Windows'
>> +	subdir_done()
>> +endif
> As you can see in other files, the reason starts always with a lowercase letter.
> Please replace the first capital letter.

Ok. I'll replace first capital letter in v3. Thanks!

>
>