[dpdk-dev] [EXT] [PATCH v1 09/12] net/octeontx2: fix the jumbo frame flag condition for mtu

[Sunil Kumar Kori]

>-----Original Message-----
>From: Steve Yang <stevex.yang at intel.com>
>Sent: Wednesday, December 9, 2020 8:46 AM
>To: dev at dpdk.org
>Cc: hemant.agrawal at nxp.com; sachin.saxena at oss.nxp.com;
>jia.guo at intel.com; haiyue.wang at intel.com; xavier.huwei at huawei.com;
>humin29 at huawei.com; yisen.zhuang at huawei.com; oulijun at huawei.com;
>beilei.xing at intel.com; jingjing.wu at intel.com; qiming.yang at intel.com;
>qi.z.zhang at intel.com; rosen.xu at intel.com; Harman Kalra
><hkalra at marvell.com>; Jerin Jacob Kollanukkaran <jerinj at marvell.com>;
>Nithin Kumar Dabilpuram <ndabilpuram at marvell.com>; Kiran Kumar
>Kokkilagadda <kirankumark at marvell.com>; Rasesh Mody
><rmody at marvell.com>; Shahed Shaikh <shshaikh at marvell.com>;
>andrew.rybchenko at oktetlabs.ru; Maciej Czekaj [C] <mczekaj at marvell.com>;
>wei.dai at intel.com; fengchunsong at huawei.com; lihuisong at huawei.com;
>ferruh.yigit at intel.com; chenhao164 at huawei.com; helin.zhang at intel.com;
>konstantin.ananyev at intel.com; yanglong.wu at intel.com;
>xiaolong.ye at intel.com; ting.xu at intel.com; xiaoyun.li at intel.com;
>wenzhuo.lu at intel.com; andy.pei at intel.com; dan.wei at intel.com; Sunil
>Kumar Kori <skori at marvell.com>; Vamsi Krishna Attunuru
><vattunuru at marvell.com>; sony.chacko at qlogic.com;
>bruce.richardson at intel.com; ivan.malov at oktetlabs.ru;
>zyta.szpak at semihalf.com; slawomir.rosek at semihalf.com;
>rad at semihalf.com; Steve Yang <stevex.yang at intel.com>
>Subject: [EXT] [PATCH v1 09/12] net/octeontx2: fix the jumbo frame flag
>condition for mtu
>
>External Email
>
>----------------------------------------------------------------------
>The jumbo frame uses the 'RTE_ETHER_MAX_LEN' as boundary condition, but
>the Ether overhead is larger than 18 when it supports dual VLAN tags.
>That will cause the jumbo flag rx offload is wrong when MTU size is
>'RTE_ETHER_MTU'.
>
>This fix will change the boundary condition with 'RTE_ETHER_MTU'.
>
>Fixes: 0e2efd02db58 ("net/octeontx2: add MTU set operation")
>
>Signed-off-by: Steve Yang <stevex.yang at intel.com>
>---
> drivers/net/octeontx2/otx2_ethdev_ops.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/net/octeontx2/otx2_ethdev_ops.c
>b/drivers/net/octeontx2/otx2_ethdev_ops.c
>index b36d37b9f7..170b8fbd91 100644
>--- a/drivers/net/octeontx2/otx2_ethdev_ops.c
>+++ b/drivers/net/octeontx2/otx2_ethdev_ops.c
>@@ -58,7 +58,7 @@ otx2_nix_mtu_set(struct rte_eth_dev *eth_dev, uint16_t
>mtu)
> 	if (rc)
> 		return rc;
>
>-	if (frame_size > RTE_ETHER_MAX_LEN)
>+	if (mtu > RTE_ETHER_MTU)
> 		dev->rx_offloads |= DEV_RX_OFFLOAD_JUMBO_FRAME;
> 	else
> 		dev->rx_offloads &= ~DEV_RX_OFFLOAD_JUMBO_FRAME;
>--
>2.17.1

Acked-by: Sunil Kumar Kori <skori at mavell.com>