[dpdk-dev] [PATCH 1/8] lib/librte_ethdev: introduce GENEVE header TLV option item
Shiri Kuzin
shirik at nvidia.com
Wed Dec 30 09:22:08 CET 2020
> -----Original Message-----
> From: Ori Kam <orika at nvidia.com>
> Sent: Tuesday, December 29, 2020 12:13 PM
> To: Stephen Hemminger <stephen at networkplumber.org>; Shiri Kuzin
> <shirik at nvidia.com>
> Cc: dev at dpdk.org; Slava Ovsiienko <viacheslavo at nvidia.com>; NBU-
> Contact-Adrien Mazarguil <adrien.mazarguil at 6wind.com>;
> ferruh.yigit at intel.com; NBU-Contact-Thomas Monjalon
> <thomas at monjalon.net>; Raslan Darawsheh <rasland at nvidia.com>
> Subject: RE: [dpdk-dev] [PATCH 1/8] lib/librte_ethdev: introduce GENEVE
> header TLV option item
>
>
>
> > -----Original Message-----
> > From: Stephen Hemminger <stephen at networkplumber.org>
> >
> > On Sun, 27 Dec 2020 18:06:16 +0200
> > Shiri Kuzin <shirik at nvidia.com> wrote:
> >
> > > +#ifdef PEDANTIC
> > > +#pragma GCC diagnostic ignored "-Wpedantic"
> > > +#endif
> >
> > Please do not introduce pragma's for pedantic in standard headers.
> > It just clutters the code unnecessarily. The rest of DPDK is not
> > guaranteed to be free of pedantic warnings, so starting now is not worth
> the mess.
>
> +1
>
> Thanks,
> Ori
Thank you for the comment.
I will update it in the revised patch set.
Thanks,
Shiri.
More information about the dev
mailing list