[dpdk-dev] [PATCH] common/mlx5: redefine Netlink include

Stephen Hemminger stephen at networkplumber.org
Tue Feb 4 09:59:34 CET 2020


On Sun,  2 Feb 2020 15:59:13 +0000
Matan Azrad <matan at mellanox.com> wrote:

> The new RDMA-CORE versions may have the same sub-path to include the
> linux Netlink header file.
> 
> It uses the pre-proccessor command #include_next what breaks the PMD gcc
> compilation of common/mlx5_netlink.h file in debug mode.
> 
> Use specific include for linux/netlink.h to be taken from
> /usr/include/linux.
> 
> Signed-off-by: Matan Azrad <matan at mellanox.com>
> ---
>  drivers/common/mlx5/mlx5_nl.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/common/mlx5/mlx5_nl.h b/drivers/common/mlx5/mlx5_nl.h
> index 2c3f837..ebaa655 100644
> --- a/drivers/common/mlx5/mlx5_nl.h
> +++ b/drivers/common/mlx5/mlx5_nl.h
> @@ -5,7 +5,7 @@
>  #ifndef RTE_PMD_MLX5_NL_H_
>  #define RTE_PMD_MLX5_NL_H_
>  
> -#include <linux/netlink.h>
> +#include "/usr/include/linux/netlink.h"

I think this should be fixed with CFLAGS, not hard coding path to netlink.h
Doing it this way is sure to break some cross build environments.


More information about the dev mailing list