[dpdk-dev] [PATCH v2] examples/tep_term: fix return value check

Ye Xiaolong xiaolong.ye at intel.com
Mon Feb 10 08:04:46 CET 2020


On 02/10, Xiaoyun Li wrote:
>Added return value check for 'rte_eth_dev_info_get()'.
>
>Coverity issue: 349922
>Fixes: 2bb43bd4350a ("examples/tep_term: add TSO offload configuration")
>Cc: stable at dpdk.org
>
>Signed-off-by: Xiaoyun Li <xiaoyun.li at intel.com>
>---
> examples/tep_termination/vxlan_setup.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>diff --git a/examples/tep_termination/vxlan_setup.c b/examples/tep_termination/vxlan_setup.c
>index eca119a72..f8385b690 100644
>--- a/examples/tep_termination/vxlan_setup.c
>+++ b/examples/tep_termination/vxlan_setup.c
>@@ -195,7 +195,9 @@ vxlan_port_init(uint16_t port, struct rte_mempool *mbuf_pool)
> 
> 	if (tso_segsz != 0) {
> 		struct rte_eth_dev_info dev_info;
>-		rte_eth_dev_info_get(port, &dev_info);
>+		retval = rte_eth_dev_info_get(port, &dev_info);
>+		if (retval != 0)
>+			return retval;
> 		if ((dev_info.tx_offload_capa & DEV_TX_OFFLOAD_TCP_TSO) == 0)
> 			RTE_LOG(WARNING, PORT,
> 				"hardware TSO offload is not supported\n");
>-- 
>2.17.1
>

Acked-by: Xiaolong Ye <xiaolong.ye at intel.com>


More information about the dev mailing list