[dpdk-dev] [PATCH v3 4/7] build: MinGW-w64 support for Meson
bruce.richardson at intel.com
Tue Feb 18 15:54:13 CET 2020
On Tue, Feb 18, 2020 at 03:26:47PM +0100, Thomas Monjalon wrote:
> 18/02/2020 01:02, Dmitry Kozlyuk:
> > --- a/config/meson.build
> > +++ b/config/meson.build
> > +# MS linker requires special treatment.
> > +# FIXME: use cc.get_linker_id() with Meson >= 0.54
> > +is_ms_linker = is_windows and (cc.get_id() == 'clang')
> Please could you replace this FIXME with an actual fix in meson.build?
Best not to at this point, as even with an explicit version check for the
new function, you can still get a warning from meson about using functions
from versions greater than baseline. In this release we have removed most,
if not all, existing warnings and I'd rather not add any back in.
Suggest replacing the fixme with a NOTE or TODO, since it's not a bug that
needs to be fixed, rather a future enhancement once we update our meson
More information about the dev