[dpdk-dev] [PATCH] app/testpmd: fix wrong return value in parse_port_list

[Iremonger, Bernard]

Hi Hariprasad,

> -----Original Message-----
> From: Govindharajan, Hariprasad <hariprasad.govindharajan at intel.com>
> Sent: Thursday, February 20, 2020 1:27 PM
> To: Lu, Wenzhuo <wenzhuo.lu at intel.com>; Wu, Jingjing
> <jingjing.wu at intel.com>; Iremonger, Bernard
> <bernard.iremonger at intel.com>
> Cc: dev at dpdk.org; Yigit, Ferruh <ferruh.yigit at intel.com>;
> stephen at networkplumber.org; david.marchand at redhat.com;
> Govindharajan, Hariprasad <hariprasad.govindharajan at intel.com>
> Subject: [PATCH] app/testpmd: fix wrong return value in parse_port_list
> 
> The function parse_port_list() is designed to return unsigned int value. After
> sanitizing the inputs, it is returning -1. Changed it to return 0.
> 
> Fixes: 2df00d562d20 ("app/testpmd: add --portlist option")
> Cc: hariprasad.govindharajan at intel.com
> 
> Signed-off-by: Hariprasad Govindharajan
> <hariprasad.govindharajan at intel.com>
> ---
>  app/test-pmd/config.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index
> 9d95202..91db508 100644
> --- a/app/test-pmd/config.c
> +++ b/app/test-pmd/config.c
> @@ -2642,7 +2642,7 @@ parse_port_list(const char *list, unsigned int
> *values, unsigned int maxsize)
>  	unsigned int marked[maxsize];
> 
>  	if (list == NULL || values == NULL)
> -		return -1;
> +		return 0;
> 
>  	for (i = 0; i < (int)maxsize; i++)
>  		marked[i] = 0;
> --
> 2.7.4

./devtools/check-git-log.sh -1
Wrong headline format:
        app/testpmd: fix wrong return value in parse_port_list
Line too long:
        Signed-off-by: Hariprasad Govindharajan <hariprasad.govindharajan at intel.com>

Otherwise:

Acked-by: Bernard Iremonger <bernard.iremonger at intel.com>