[dpdk-dev] [PATCH v2] net/vhost: fix return value of vhost creates not checked

wangyunjian wangyunjian at huawei.com
Tue Jan 7 04:15:00 CET 2020


Thanks, I will fix it in v3.

Yunjian
> -----Original Message-----
> From: Tiwei Bie [mailto:tiwei.bie at intel.com]
> Sent: Tuesday, January 7, 2020 10:32 AM
> To: wangyunjian <wangyunjian at huawei.com>
> Cc: dev at dpdk.org; maxime.coquelin at redhat.com; zhihong.wang at intel.com;
> xudingke <xudingke at huawei.com>; stable at dpdk.org
> Subject: Re: [PATCH v2] net/vhost: fix return value of vhost creates not checked
> 
> On Tue, Dec 17, 2019 at 09:36:17AM +0800, Yunjian Wang wrote:
> >
> > -	eth_dev_vhost_create(dev, iface_name, queues, dev->device.numa_node,
> > -		flags, disable_flags);
> > +	ret = eth_dev_vhost_create(dev, iface_name, queues,
> > +				   dev->device.numa_node, flags, disable_flags);
> > +	if (ret == -1)
> > +		VHOST_LOG(ERR, "Failed to create %s", name);
> 
> A newline is needed at the end of the error message.
> Other than that,
> 
> Reviewed-by: Tiwei Bie <tiwei.bie at intel.com>


More information about the dev mailing list