[dpdk-dev] [PATCH] librte_ethdev: extend dpdk api led control to query capability

Thomas Monjalon thomas at monjalon.net
Wed Jan 8 15:07:51 CET 2020


08/01/2020 14:58, Laurent Hardy:
> About the 'is_supported()' versions of APIs, in the current patch I 
> factorize
> the check on dev ops on and off availability in a same function named
> "led_ctrl_capable" but I can rename it if required.
> 
> Just in this specific case I don't dissociate on and off capability, as 
> being
> able to set the led off without a way to set it on again sounds a bit 
> unusual :)
> 
> > The other alternatives are in rte_eth_dev_info and dev_flags.

Basically we just need to decide whether we prefer a new function
or a new flag.

Until now, capabilities were given in flags.
Why a function here?




More information about the dev mailing list