[dpdk-dev] [PATCH] net/af_xdp: fix redundant check for NEED WAKEUP

Loftus, Ciara ciara.loftus at intel.com
Wed Jan 8 16:57:00 CET 2020


> 
> Function kick_tx() has built-in detection on NEED_WAKEUP flag, so just
> call it directly, like elsewhere in the driver.
> 
> Fixes: d8a210774e1d ("net/af_xdp: support unaligned umem chunks")
> Cc: stable at dpdk.org
> 
> Signed-off-by: Xiao Wang <xiao.w.wang at intel.com>
> ---
>  drivers/net/af_xdp/rte_eth_af_xdp.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c
> b/drivers/net/af_xdp/rte_eth_af_xdp.c
> index 2b1245ee4..d903e6c28 100644
> --- a/drivers/net/af_xdp/rte_eth_af_xdp.c
> +++ b/drivers/net/af_xdp/rte_eth_af_xdp.c
> @@ -480,10 +480,7 @@ af_xdp_tx_zc(void *queue, struct rte_mbuf **bufs,
> uint16_t nb_pkts)
>  		tx_bytes += mbuf->pkt_len;
>  	}
> 
> -#if defined(XDP_USE_NEED_WAKEUP)
> -	if (xsk_ring_prod__needs_wakeup(&txq->tx))
> -#endif
> -		kick_tx(txq);
> +	kick_tx(txq);
> 
>  out:
>  	xsk_ring_prod__submit(&txq->tx, count);
> --
> 2.15.1


Thanks for the patch.

Tested-by: Ciara Loftus <ciara.loftus at intel.com>



More information about the dev mailing list