[dpdk-dev] [PATCH v4 6/9] eal: add function to detect process type

[Stephen Hemminger]

On Wed,  8 Jan 2020 19:13:09 -0800
Pallavi Kadam <pallavi.kadam at intel.com> wrote:

Minor comments

>  /* Address of global and public configuration */
> -static struct rte_config rte_config;
> +static struct rte_config rte_config = {
> +		.mem_config = &early_mem_config,
> +};

Only single tab is needed for indent here

+enum rte_proc_type_t
+	eal_proc_type_detect(void)

put function in column 1.

enum rte_proc_type_t
eal_proc_type_detect(void)

In a related vain, the existing code fore eal_create_cpu_map does
not follow DPDK coding style at all. It has weird indentation of
for loops and uses C99 style declarations of loop variables.
I guess nobody on Linux side ever looked at the Windows code for that.