[dpdk-dev] [PATCH] net/ixgbe: fix build for gcc 4.8.5

Ferruh Yigit ferruh.yigit at intel.com
Wed Jan 15 17:50:31 CET 2020


On 1/15/2020 10:17 AM, Ye Xiaolong wrote:
> On 01/14, Ferruh Yigit wrote:
>> Build error:
>>  In function ‘ixgbe_recv_pkts_lro_bulk_alloc’:
>> ../drivers/net/ixgbe/ixgbe_rxtx.c:2209:24:
>>  error: ‘next_sc_entry’ may be used uninitialized in this function
>>  [-Werror=maybe-uninitialized]
>>    next_sc_entry->fbuf = first_seg;
>>                        ^
>> http://mails.dpdk.org/archives/test-report/2020-January/113891.html
>>
>> This is a compiler false positive and error not seen by newer compilers,
>> or clang but to fix the warning initializing the complained variable.
>>
>> According git bisect, no idea how:
>> Fixes: 8a2e7ce976fd ("net/ixgbe: avoid multiple definitions of bool")
>>
>> Reported-by: Maxime Coquelin <maxime.coquelin at redhat.com>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit at intel.com>
>> ---
>> Cc: dharmik.thakkar at arm.com
>> ---
>> drivers/net/ixgbe/ixgbe_rxtx.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c
>> index 13b06eb9c..30f890572 100644
>> --- a/drivers/net/ixgbe/ixgbe_rxtx.c
>> +++ b/drivers/net/ixgbe/ixgbe_rxtx.c
>> @@ -2028,7 +2028,7 @@ ixgbe_recv_pkts_lro(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts,
>> 		bool eop;
>> 		struct ixgbe_rx_entry *rxe;
>> 		struct ixgbe_scattered_rx_entry *sc_entry;
>> -		struct ixgbe_scattered_rx_entry *next_sc_entry;
>> +		struct ixgbe_scattered_rx_entry *next_sc_entry = NULL;
>> 		struct ixgbe_rx_entry *next_rxe = NULL;
>> 		struct rte_mbuf *first_seg;
>> 		struct rte_mbuf *rxm;
>> -- 
>> 2.24.1
>>
> 
> Acked-by: Xiaolong Ye <xiaolong.ye at intel.com>
> 

Applied to dpdk-next-net/master, thanks.


More information about the dev mailing list