[dpdk-dev] [PATCH v6 0/6] implement common rte bit operation APIs in PMDs
David Marchand
david.marchand at redhat.com
Fri Jan 17 14:03:42 CET 2020
On Wed, Dec 18, 2019 at 7:00 AM Joyce Kong <joyce.kong at arm.com> wrote:
>
> There are a lot functions of bit operations scattered in PMDs, consolidate
> them into a common API family and applied in different PMDs to reduce code
> duplication.
>
> v6:
> Trim 'unsigned long' in PMDs down to 'uint32_t', as on mainstream 64-bit OS,
> 'unsigned long' is 64-bit in size, but the 32-bit OS expects 32-bit 'unsigned
> long' argument.
>
> v5:
> Correct the spelling mistake in test_bitops.c
>
> v4:
> Introduce uint32_t/uint64_t *addr when definiting bit operation APIs(suggested by
> Morten Brørup).
>
> v3:
> 1. Change the API's head file back to rte_bitops.h, then implement both 32-bit and
> 64-bit operations with and without C11 atomic memory ordering.
> 2. Add multi-core test case for bit operations which implemented with memory ordering.
> 3. Modify the doc of both APIs and test cases.
>
> v2:
> 1. Add doxygen comments for the rte bit operation API(suggested by Stephen Hemminger).
> 2. Add test cases for common rte bit operation API(suggested by Stephen Hemminger).
> 3. Change the header file to rte_io_bitops.h and the operation to rte_io_set_bit()etc.,
> as the API uses barriers inside and the barriers are only needed for IO operations
> (suggested by Jerin Jacob).
> 4. Use an well defined uint_NN_t type(suggested by Morten Brørup).
I did not wait for travis to finish but afaics, this series only
builds on 32bits and AARCH64.
https://travis-ci.com/david-marchand/dpdk/builds/144927372
--
David Marchand
More information about the dev
mailing list