[dpdk-dev] [dpdk-stable] [PATCH] app/test: fix dependency on file in /sys

Thomas Monjalon thomas at monjalon.net
Mon Jan 20 16:29:35 CET 2020


20/01/2020 13:22, Bruce Richardson:
> Meson versions 0.52 and 0.53 are being overly smart and detecting the path
> "/sys/devices/system/cpu/present" in the call to cat in
> app/test/meson.build and then adding it as a dependency to the build
> configuration. This causes issues on systems where the timestamp of that
> file always returns the current time, since it means that the build.ninja
> file is always out of date, and therefore needs to be rebuilt.
> 
> We can fix this by just using a simple shell script to return the coremask
> appropriately for BSD and Linux, and removing that code logic from meson -
> thereby hiding the use of the /sys file.
> 
> Fixes: c70622ac6f72 ("test: detect number of cores with meson")
> Cc: aconole at redhat.com
> Cc: stable at dpdk.org
> 
> Signed-off-by: Bruce Richardson <bruce.richardson at intel.com>

Thanks a lot Bruce, meson stops reconfiguring, this is a life changer!

Applied (with new script added in MAINTAINERS), thanks




More information about the dev mailing list