[dpdk-dev] [dpdk-stable] [PATCH] test/compress: replace test vector

[Mcnamara, John]

> -----Original Message-----
> From: Thomas Monjalon <thomas at monjalon.net>
> Sent: Monday, January 20, 2020 2:33 PM
> To: Trahe, Fiona <fiona.trahe at intel.com>; Trybula, ArturX
> <arturx.trybula at intel.com>; Mcnamara, John <john.mcnamara at intel.com>
> Cc: dev at dpdk.org; stable at dpdk.org; shallyv at marvell.com; Dybkowski, AdamX
> <adamx.dybkowski at intel.com>; Danilewicz, MarcinX
> <marcinx.danilewicz at intel.com>; Akhil Goyal <akhil.goyal at nxp.com>
> Subject: Re: [dpdk-stable] [PATCH] test/compress: replace test vector
> 
> 20/01/2020 14:54, Mcnamara, John:
> > From: stable <stable-bounces at dpdk.org> On Behalf Of Thomas Monjalon
> > > 15/01/2020 16:54, Akhil Goyal:
> > > > > >
> > > > > > This patch replaces existing test vector with a new one
> > > > > > containing C code to fix license issue.
> > > > > >
> > > > > > Signed-off-by: Artur Trybula <arturx.trybula at intel.com>
> > > > > Acked-by: Fiona Trahe <fiona.trahe at intel.com>
> > > > Applied to dpdk-next-crypto
> > >
> > > This is a terrible idea.
> > > Adding C code in a C project as text, and worst, its own code, will
> > > make grep matching on fake text.
> >
> > Hi,
> >
> > I don't think this is a valid criticism. The patch replace code in
> Pascal with some code in C as a compression test. The grep part isn't
> really relevant, it should be clear to anyone who finds a match.
> >
> > If you have a strong objection we will replace it with some more public
> domain text.
> 
> Yes please, it will be less confusing.
> 
> > > Why do you need so much text to compress?
> 
> Please why do we need some code at all?
> 
> > > Why not just opening our own code files as text?
> >
> > That probably isn't worth the effort.
> >
> > > Why stable at dpdk.org is Cc'ed in this email?
> >
> > Ok. We'll do that.
> 
> I say Why? You say Ok :-)

I mis-read it. I thought you said it wasn't CCed.

John