[dpdk-dev] [PATCH v3 9/9] net/bnxt: fix coverity warnings

Ferruh Yigit ferruh.yigit at intel.com
Wed Jan 29 13:30:59 CET 2020


On 1/28/2020 9:01 PM, Ajit Khaparde wrote:
> From: Kalesh AP <kalesh-anakkur.purayil at broadcom.com>
> 
> return value stored in "ret" but it has been overwritten before use.
> 
> CID 353621:  Code maintainability issues  (UNUSED_VALUE)
> Fixes: 7fe5668d2ea3 ("net/bnxt: support VLAN filter and strip")
> Fixes: df6cd7c1f73a ("net/bnxt: handle reset notify async event from FW")
> Cc: stable at dpdk.org
> 
> Signed-off-by: Kalesh AP <kalesh-anakkur.purayil at broadcom.com>
> Reviewed-by: Ajit Khaparde <ajit.khaparde at broadcom.com>
> Signed-off-by: Somnath Kotur <somnath.kotur at broadcom.com>

Hi Kalesh,

The patch title doesn't really say much, it should say the actual reason not
just fixing a tools warning, I am updating it as:

"net/bnxt: fix return value check"

Also the defined syntax for Coverity issues is:
Coverity issue: ####

For this case it should be:
Coverity issue: 353621


More information about the dev mailing list