[dpdk-dev] [PATCH] app/testpmd: fix copying the name of the dynflag
Ori Kam
orika at mellanox.com
Thu Jan 30 14:22:44 CET 2020
When working with testpmd and setting the dynflag name, we copy the
name given by the cmd to the dynflag name.
The issue is that the size of the dynflag name is smaller then the
string used by testpmd.
This commit solves this issue by usign strncpy.
Coverity issue: 353610
Fixes: b57b66a97ebf ("app/testpmd: support mbuf dynamic flag")
Signed-off-by: Ori Kam <orika at mellanox.com>
---
app/test-pmd/cmdline.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index dab22bc..09429f9 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -18867,7 +18867,7 @@ struct cmd_config_tx_dynf_specific_result {
return;
flag = rte_mbuf_dynflag_lookup(res->name, NULL);
if (flag <= 0) {
- strcpy(desc_flag.name, res->name);
+ strncpy(desc_flag.name, res->name, sizeof(*desc_flag.name));
desc_flag.flags = 0;
flag = rte_mbuf_dynflag_register(&desc_flag);
if (flag < 0) {
--
1.8.3.1
More information about the dev
mailing list