[dpdk-dev] [PATCH v6 03/10] eal: include filesystem implementation for windows

[Pallavi Kadam]

Hi Dmitry,

Thank you for reviewing the code and for your comments.

On 1/30/2020 10:04 PM, Dmitry Kozliuk wrote:
> Hello Pallavi,
>
>> +#include "eal_internal_cfg.h"
>> +
>> +/* sets up platform-specific runtime data dir */
>> +int
>> +eal_create_runtime_dir(void);
>> +
>> +/* returns runtime dir */
>> +const char *
>> +eal_get_runtime_dir(void);
> Any reason not to #include "eal_filesystem.h"?

Do you mean, we can exclude "eal_filesystem.h" in the current patchset?
If so, you are correct. This file was required before to include
eal_runtime_config_path() when compiling with VS/ ICC, I think.
But, now 'common' version of eal_filesystem.h can be used for Windows.
For other function definitions, we can always #include "eal_filesystem.h"
if require later.

>
>> +
>> +static inline const char *
>> +eal_runtime_config_path(void)
>> +{
>> +	static char buffer[PATH_MAX];  /* static so auto-zeroed */
>> +	char  Directory[PATH_MAX];
> Should be "directory" according to the style guide.

Thanks, will be sending out new version and excluding this file
as mentioned above.

>
>> +
>> +	GetTempPathA(sizeof(Directory), Directory);
>> +	snprintf(buffer, sizeof(buffer)-1, RUNTIME_CONFIG_FMT, Directory,
> Style guide requires spaces around binary "-".
>
>> +static inline const char *
>> +eal_hugepage_info_path(void)
>> +{
>> +	static char buffer[PATH_MAX];  /* static so auto-zeroed */
>> +	TCHAR  Directory[PATH_MAX];
> Should be "directory", see above.