[dpdk-dev] [PATCH 17/21] net/ixgbe/base: improve log about autonego being disabled

[Sun, GuinanX]

Hi  Ferruh

> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Monday, June 22, 2020 8:01 PM
> To: Sun, GuinanX <guinanx.sun at intel.com>; dev at dpdk.org
> Cc: Chylkowski, JakubX <jakubx.chylkowski at intel.com>
> Subject: Re: [dpdk-dev] [PATCH 17/21] net/ixgbe/base: improve log about
> autonego being disabled
> 
> On 6/12/2020 4:24 AM, Guinan Sun wrote:
> > On ESXi OS, when user disables auto negotiation, the following log
> > appears: "(unsupported) Flow control autoneg is disabled".
> 
> Is ESXi reference valid for the DPDK commit?

I think this is no problem, because there are a lot of commit information including'ESXi' in dpdk .
For example the following version:
{
	commit dfedf3e3f9d281fbe493cc98fd9ef82bec42fdec
	Author: Viacheslav Ovsiienko <viacheslavo at mellanox.com>
	Date: Tue Jul 30 09:20:24 2019 +0000

	 net/mlx5: add workaround for VLAN in virtual machine
}

{
	commit 18c8e84d7726ad16bb81fdb7649e13202997cd41
	Author: Gautam Dawar <gdawar at solarflare.com>
	Date: Mon Jun 10 08:38:39 2019 +0100

	     net/sfc/base: support proxy auth operations for SR-IOV
}...

So there should be no correction.

> 
> > It is true that AN is disabled but it is not necessarily true that it
> > is not supported.
> >
> > Signed-off-by: Jakub Chylkowski <jakubx.chylkowski at intel.com>
> > Signed-off-by: Guinan Sun <guinanx.sun at intel.com>
> 
> <...>