[dpdk-dev] [PATCH 2/2] ring: empty optimization

David Marchand david.marchand at redhat.com
Wed Jul 1 11:19:53 CEST 2020


On Tue, May 19, 2020 at 6:02 PM Morten Brørup <mb at smartsharesystems.com> wrote:
> > Blank line after declarations?
> >
> > Are the temporary variable even needed?
>
> Personally, I agree with you, but I was trying to match the existing coding style of the closely related rte_ring_count() function - only to avoid this kind of feedback.
>
> Damn if you do, damn if you don't. :-)

Yes, looking at the code, it seems fair taking this patch as is.


-- 
David Marchand



More information about the dev mailing list